Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dart snippets #5

Merged
merged 17 commits into from
Jul 8, 2024
Merged

Add dart snippets #5

merged 17 commits into from
Jul 8, 2024

Conversation

ok300
Copy link
Collaborator

@ok300 ok300 commented Jul 3, 2024

No description provided.

@ok300 ok300 changed the title Add dart snippets [Draft] Add dart snippets Jul 3, 2024
@ok300 ok300 changed the title [Draft] Add dart snippets Add dart snippets Jul 5, 2024
ok300 and others added 3 commits July 5, 2024 12:51
* Add extension on Config
* Fix indentation
* Fix enum name
* Add print statements to remove unused_variable warnings
* Remove unused import
Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I have one suggestion.

Since we've opted to a more free approach on managing wallet & SDK streams, we should reference & informs users that snippets rely on this example helper class: snippets/dart_snippets/lib/sdk_instance.dart on getting started page.

Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ok300 ok300 merged commit 6bef82c into main Jul 8, 2024
31 of 32 checks passed
@ok300 ok300 deleted the ok300-add-dart-snippets branch July 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants