-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ci for swift #620
add ci for swift #620
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One thing to note is that RN depends on the swift build so right now we will need to publish first the swift and make sure it passes and then run all other platforms unless there is a way to only run RN if swift passes...
Good point. I'll see if I can make React native run only if swift completes, regardless of whether swift was being built or not. |
f15dfcc
to
9091982
Compare
Closing in favor of #1033 |
Move the Swift CI into the sdk repo.
Needs a secret to be set:
COCOAPODS_TRUNK_TOKEN