[Tooltip]: Validates arrow positioning / adds timeout props #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminknox
requested review from
fallaciousreasoning,
petemill and
AlanBreck
as code owners
benjaminknox
force-pushed
the
bpk/fix-tooltip-arrow-position-bug
branch
from
d6fc52e to
65732be
Compare
fallaciousreasoning
approved these changes
Nov 1, 2023
| /* Whether the tooltip is currently visible */ | ||
| export let visible: boolean | undefined = undefined | ||
|
|
||
| /** The length of time in ms the tooltip element takes to fade | ||
| * after the users mouse leaves the trigger or tooltip*/ | ||
| export let fadeDuration: number = 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in main, if you hover over a tooltip and hover out a few times, the arrow positioning sometimes computes incorrectly. This fixes it by validating arrow positioning before firing the
computedpositionevent on theFloatingelement.This PR also adds a few other things discussed with @fallaciousreasoning, a prop named
mouseleaveTimeoutfor the debounce timeout on the mouse leave event, and defaults to no fadeout animation on the tooltip, with a prop namedfadeDurationto set it if desired.Screenshots
Arrow Position Bug Before
Screen.Recording.2023-10-31.at.3.38.30.PM.mov
Arrow Position Bug After
Screen.Recording.2023-10-31.at.3.39.18.PM.mov
Screen.Recording.2023-10-31.at.4.35.19.PM.mov