Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified macOS installation to only use native tools #46

Closed
wants to merge 13 commits into from
Closed

Modified macOS installation to only use native tools #46

wants to merge 13 commits into from

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented Jan 8, 2025 •
edited
Loading 

$ curl -fsS https://raw.githubusercontent.com/brave/install.sh/refs/heads/wknapik-macos-installation-without-extra-dependencies/install.sh|sh
+ hdiutil attach -quiet https://laptop-updates.brave.com/latest/osx
+ rsync -a --del '/Volumes/Brave Browser/Brave Browser.app' /Applications/
+ hdiutil detach -force -quiet '/Volumes/Brave Browser'
Installation complete! Start Brave by typing: open -a Brave\ Browser
$

@wknapik wknapik self-assigned this Jan 8, 2025
@wknapik wknapik marked this pull request as ready for review January 8, 2025 21:04
@wknapik wknapik requested a review from fmarier as a code owner January 8, 2025 21:04
wknapik
wknapik commented Jan 8, 2025
View reviewed changes
install.sh Outdated Show resolved Hide resolved
wknapik
wknapik commented Jan 8, 2025
View reviewed changes
install.sh Show resolved Hide resolved
wknapik
wknapik commented Jan 8, 2025
View reviewed changes
install.sh Outdated Show resolved Hide resolved
@fmarier
Copy link
Member

fmarier commented Jan 8, 2025

We should get someone familiar with macOS to review these changes to make sure that it's the right approach.

wknapik
wknapik commented Jan 9, 2025
View reviewed changes
install.sh Show resolved Hide resolved
mihaiplesa
mihaiplesa previously approved these changes Jan 9, 2025
View reviewed changes
@wknapik wknapik force-pushed the wknapik-macos-installation-without-extra-dependencies branch from a764da9 to a0453c3 Compare January 13, 2025 19:43
bridiver
bridiver reviewed Jan 13, 2025
View reviewed changes
install.sh
@@ -36,7 +36,7 @@ main() {

## Find and/or install the necessary tools

if [ "$(id -u)" = 0 ] || [ "$os" = Darwin ]; then
if am_admin; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we ever want to install using sudo on macos

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would only happen if the user is not in the admin group, which is necessary to install in /Applications without sudo.

Or is there something else that would be better to do in this case?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't seem right, but I guess I have never really used an account that isn't in the admin group. I think it's likely very uncommon

@diracdeltas
Copy link
Member

Discussed on Slack; consensus from MacOS users is we'd prefer if this were reverted to NOT supporting MacOS https://bravesoftware.slack.com/archives/C01EVLWS8R5/p1736803102037269?thread_ts=1736437286.640829&cid=C01EVLWS8R5

@wknapik
Copy link
Collaborator Author

wknapik commented Jan 14, 2025

Will remove macOS support after #47 goes in

@wknapik wknapik closed this Jan 14, 2025
@wknapik
Copy link
Collaborator Author

wknapik commented Jan 15, 2025

macOS support is removed in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

@mihaiplesa mihaiplesa mihaiplesa approved these changes

@fmarier fmarier Awaiting requested review from fmarier fmarier is a code owner

Assignees

@wknapik wknapik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wknapik @fmarier @diracdeltas @bridiver @mihaiplesa