-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeHealth][rust] bump tracing-subscriber 0.2 -> 0.3 #27740
Conversation
c516301
to
e398f85
Compare
e398f85
to
e6d9fa5
Compare
[puLL-Merge] - brave/brave-core@27740 Here's my analysis of this pull request: DescriptionThis PR downloads and reverts the tracing-subscriber dependency from v0.3 to v0.2 in the Brave browser's SKUS component. The change includes downgrading several related dependencies and adding new ones to support the older version. Possible Issues
Security Hotspots
ChangesChangesBy filename:
sequenceDiagram
participant Build as Build System
participant SKUs as SKUS Component
participant Tracing as Tracing Subscriber
participant Format as Log Formatter
Build->>SKUs: Initialize
SKUs->>Tracing: Initialize v0.2 subscriber
Tracing->>Format: Configure formatter
Format->>Format: Apply ANSI settings
Format->>SKUs: Return formatted log
SKUs->>Build: Complete initialization
|
That's backwards |
Moved the whole thing into #27745 |
Resolves brave/brave-browser#44129
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: