Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeHealth] Use cxx20's T::contains pt.2 #27709

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Feb 18, 2025

In cxx20, there is a new function in associative containers called contains, which should be used as a replacement to base::Contains.

Resolves brave/brave-browser#44063

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium self-assigned this Feb 18, 2025
@cdesouza-chromium cdesouza-chromium requested review from a team and goodov as code owners February 18, 2025 15:28
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
In `cxx20`, there is a new function in associative containers called
`contains`, which should be used as a replacement to `base::Contains`.

Resolves brave/brave-browser#44063
@cdesouza-chromium cdesouza-chromium merged commit b54f97e into master Feb 19, 2025
18 checks passed
@cdesouza-chromium cdesouza-chromium deleted the use-type-contains-pt2 branch February 19, 2025 13:28
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 19, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.53

kdenhartog pushed a commit that referenced this pull request Feb 19, 2025
In `cxx20`, there is a new function in associative containers called
`contains`, which should be used as a replacement to `base::Contains`.

Resolves brave/brave-browser#44063
cdesouza-chromium added a commit that referenced this pull request Feb 20, 2025
cdesouza-chromium added a commit that referenced this pull request Feb 20, 2025
wknapik pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to T::contains from base::Contains - part 2
6 participants