Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] RichNTT: Android #27645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[ads] RichNTT: Android #27645

wants to merge 1 commit into from
+676 −10

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Feb 13, 2025 •
edited
Loading

Resolves brave/brave-browser#43513

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions GitHub Actions
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@aseren aseren changed the title WIP: Rich ntt on Android WIP: Rich NTT on Android Feb 18, 2025
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 18, 2025
@aseren aseren force-pushed the issues/43513 branch 4 times, most recently from 8e189c5 to 42569fa Compare February 20, 2025 20:04
@aseren aseren changed the title WIP: Rich NTT on Android Rich NTT on Android Feb 20, 2025
@aseren aseren changed the title Rich NTT on Android [ads] RichNTT: Android Feb 20, 2025
@aseren aseren force-pushed the issues/43513 branch 2 times, most recently from fbb6db3 to 0ef68e4 Compare February 20, 2025 22:09
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 20, 2025
@aseren aseren force-pushed the issues/43513 branch 2 times, most recently from 4c02a83 to 78d1c83 Compare February 21, 2025 15:18
@aseren aseren force-pushed the issues/43513 branch 3 times, most recently from 786d583 to 380b677 Compare February 21, 2025 16:23
@aseren aseren marked this pull request as ready for review February 21, 2025 16:27
@aseren aseren requested review from a team, deeppandya and bridiver as code owners February 21, 2025 16:28
@aseren aseren requested a review from a team as a code owner February 21, 2025 16:28
SergeyZhukovsky
SergeyZhukovsky reviewed Feb 21, 2025
View reviewed changes
android/java/res/layout/new_tab_page_layout.xml
android:id="@+id/bg_background_view"
android:layout_width="match_parent"
android:layout_height="match_parent">
</FrameLayout>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it to be android:visibility="gone"?

SergeyZhukovsky
SergeyZhukovsky reviewed Feb 21, 2025
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/SponsoredBackgroundWebView.java
windowAndroid,
WebContents.createDefaultInternalsHolder());

final IntentRequestTracker intentRequestTracker = windowAndroid.getIntentRequestTracker();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why intentRequestTracker has to be final, could windowAndroid.getIntentRequestTracker() passed directly to create?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same about final ContentView webContentView, final ViewAndroidDelegate delegate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky left review comments

@tmancey tmancey Awaiting requested review from tmancey

@deeppandya deeppandya Awaiting requested review from deeppandya deeppandya is a code owner

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

@stoletheminerals stoletheminerals Awaiting requested review from stoletheminerals

At least 1 approving review is required to merge this pull request.

Assignees

@aseren aseren

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ads] RichNTT: Android
2 participants
@aseren @SergeyZhukovsky