-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Add alternative app icons #27183
base: master
Are you sure you want to change the base?
Conversation
f60f79e
to
fb1da38
Compare
[puLL-Merge] - brave/brave-core@27183 DescriptionThis PR adds support for alternate app icons in the Brave iOS app. It introduces a new settings page where users can choose from a variety of custom app icons, including themed and nostalgic designs. ChangesChanges
sequenceDiagram
participant User
participant SettingsViewController
participant AltIconsView
participant AltIconsModel
participant UIApplication
User->>SettingsViewController: Taps "Change App Icon"
SettingsViewController->>AltIconsView: Present AltIconsView
User->>AltIconsView: Selects new icon
AltIconsView->>AltIconsModel: setAlternateAppIcon(icon)
AltIconsModel->>UIApplication: setAlternateIconName(iconName)
UIApplication-->>AltIconsModel: Icon change result
AltIconsModel-->>AltIconsView: Update UI
AltIconsModel-->>SettingsViewController: Notify of icon change
SettingsViewController->>SettingsViewController: Update icon in settings list
Possible Issues
Security HotspotsNone identified. The changes are primarily UI-related and don't involve sensitive data handling or security-critical operations. |
fb1da38
to
6335d85
Compare
Resolves brave/brave-browser#43141
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: