Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"IPFSEnabled" Group Policy Documentation is No Longer Relevant #27086

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Dec 23, 2024

Resolves brave/brave-browser#41529

added the Brave policy: "IPFSEnabled" to be listed as Deprecated instead of error

image

Deprecated here: brave/brave-browser#37735

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Configure Group Policy (documentation: https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy)
  2. Add the IPFSEnabled policy to the json file
  3. Make sure that IPFSEnabled is present in the Chrome Policies list, and it is marked as deprecated

@vadimstruts vadimstruts marked this pull request as ready for review January 5, 2025 15:50
@vadimstruts vadimstruts requested a review from darkdh January 5, 2025 15:51
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vadimstruts vadimstruts removed the request for review from darkdh January 14, 2025 14:43
@vadimstruts vadimstruts merged commit 6db5e4c into master Jan 14, 2025
19 checks passed
@vadimstruts vadimstruts deleted the 41529-ipfsenabled-group-policy-documentation-is-no-longer-relevant branch January 14, 2025 14:45
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 14, 2025
brave-builds added a commit that referenced this pull request Jan 14, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.13

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 Pro x64 using the following build(s):

Brave | 1.76.13 Chromium: 132.0.6834.83 (Official Build) nightly (64-bit)
-- | --
Revision | 886363cccfee3d0d19418354fe0894e2fa676a57
OS | Windows 11 Version 24H2 (Build 26100.2605)

I couldn't find the IPFSEnabled policy via the .adm file that I downloaded from https://support.brave.com/hc/en-us/articles/360039248271-Group-Policy. However, using the method @bsclifton mentioned via brave/brave-browser#26502 (comment) re: adding the policies manually via the registry, I was able to reproduce/verify that the IPFSEnabled appears as Deprecated rather than Error as per the following:

  • navigate to Computer\HKEY_CURRENT_USER\Software\Policies\BraveSoftware\Brave
  • create a REG_DWORD named IPFSEnabled and ensure it's set as 0 (screenshot below)
  • launch 1.76.13 Chromium: 132.0.6834.83 and ensure that IPFSEnabled appears as deprecated under brave://policy

image

1.76.11 Chromium: 132.0.6834.83 (broken) 1.76.13 Chromium: 132.0.6834.83 (fixed)
reproducedError fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"IPFSEnabled" Group Policy Documentation is No Longer Relevant
4 participants