Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun compare-chromium-versions in all PRs after a chromium major version update on their target branch (uplift to 1.71.x) #26063

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Rerun compare-chromium-versions in all PRs after a chromium major version update on their target branch (uplift to 1.71.x) #26063

merged 1 commit into from
Oct 17, 2024
+47 −0

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 17, 2024 •
edited by LaurenWags
Loading

Uplift of #26061

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner October 17, 2024 14:11
@brave-builds brave-builds added this to the 1.71.x - Release milestone Oct 17, 2024
@brave-builds brave-builds self-assigned this Oct 17, 2024
@wknapik wknapik added CI/skip Do not run CI builds (except noplatform) CI/skip-teamcity Do not run builds in TeamCity QA/No labels Oct 17, 2024
LaurenWags
LaurenWags approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.71.x is approved 👍🏻

@LaurenWags LaurenWags merged commit ba8d462 into 1.71.x Oct 17, 2024
16 checks passed
@LaurenWags LaurenWags deleted the pr26061_wknapik-rerun-compare-chromium-versions-in-all-prs-on-chromium-bump_1.71.x branch October 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip Do not run CI builds (except noplatform) CI/skip-teamcity Do not run builds in TeamCity QA/No
Projects
None yet
Milestone
1.71.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @LaurenWags @wknapik