Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dumps without crashing in updater::DoPeriodicTasks (uplift to 1.72.x) #26057

Open
wants to merge 1 commit into
base: 1.72.x
Choose a base branch
from

Conversation

mherrmann
Copy link
Collaborator

Uplift of #26037
Resolves brave/brave-browser#41360

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@mherrmann mherrmann self-assigned this Oct 17, 2024
@deeppandya
Copy link
Contributor

@mherrmann base for the pr should be 1.72 instead of master

@mherrmann mherrmann changed the base branch from master to 1.72.x October 17, 2024 05:59
@mherrmann mherrmann requested a review from a team as a code owner October 17, 2024 05:59
@mherrmann
Copy link
Collaborator Author

@deeppandya thanks!

@mherrmann mherrmann removed request for a team October 17, 2024 06:00
@mherrmann mherrmann removed request for a team, bsclifton and deeppandya October 17, 2024 06:00
@mherrmann mherrmann added this to the 1.72.x - Beta milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C130] unexpected messages in logs
2 participants