Commits on Oct 16, 2024

1. [DanglingPtr] Cherry-pick upstream build failure fix …

   I had to spend some significant bysecting this and it turns out rust
   tools don't support sanitisers, which was breaking the experimental
   build with dangling pointers.
   
   Chromium change:
   https://chromium.googlesource.com/chromium/src/+/b250fcef54d8631d6fc09d1936980fa81ccaf4d0
   
   commit b250fcef54d8631d6fc09d1936980fa81ccaf4d0
   Author: danakj <[email protected]>
   Date:   Tue Oct 1 17:57:51 2024 +0000
   
       Disable PA-based features in the Rust host tools toolchain (proc macros)
   
       If the user explicitly turns on ASAN and use_raw_ptr_asan_unowned_impl
       we don't want to use those in the host tools toolchain. Elsewhere we
       disable ASAN in the toolchain in build/config/sanitizers/sanitizers.gni:
       ```
       if (!is_a_target_toolchain || toolchain_for_rust_host_build_tools) {
         is_asan = false
       ```
   
       But that leaves use_raw_ptr_asan_unowned_impl on without ASAN which then
       causes GN assertions and badness.
   
       The rust host tools toolchain should just use default allocators anyway
       so that the proc macro DLLs use the same allocator as the compiler that
       dlopens them.
   
       Bug: 40212971

   

   cdesouza-chromium committed Oct 16, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 12c036b
   • Browse repository at this point

   Copy the full SHA

   12c036b View commit details

   Browse the repository at this point in the history