Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): 0x Recipient Label on Transaction Confirmed Screen #26038

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where the Transaction Confirmed screen was not showing the Recipient label for 0x transactions.

Resolves brave/brave-browser#41672

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and create a swap using 0x
  2. Wait for the Transaction to be confirmed
  3. Recipient Account or Address should not be missing.

Before:

Image

After:

Image

@Douglashdaniel Douglashdaniel self-assigned this Oct 16, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner October 16, 2024 15:27
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Oct 16, 2024
@Douglashdaniel Douglashdaniel force-pushed the fix-wallet-0x-recipient-label-on-transaction-confirmed-screen branch from cfcd158 to bd6d33f Compare October 16, 2024 15:53
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 0ab1734 into master Oct 17, 2024
17 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-0x-recipient-label-on-transaction-confirmed-screen branch October 17, 2024 14:51
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 17, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient not displayed for 0x Swaps
3 participants