Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hamburge menu for VPN #26005

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update hamburge menu for VPN #26005

merged 1 commit into from
Oct 15, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Oct 15, 2024

Resolves brave/brave-browser#41591
Resolves brave/brave-browser#41592

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

With new update, hamburge menu should like : brave/brave-browser#41591 (comment)

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Oct 15, 2024
@deeppandya deeppandya added this to the 1.73.x - Nightly milestone Oct 15, 2024
@deeppandya deeppandya self-assigned this Oct 15, 2024
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya merged commit d17b06d into master Oct 15, 2024
18 checks passed
@deeppandya deeppandya deleted the update_hamburger_menu_vpn branch October 15, 2024 19:20
brave-builds added a commit that referenced this pull request Oct 15, 2024
brave-builds added a commit that referenced this pull request Oct 15, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.14

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 15 using the following build(s):

Brave | 1.73.22 Chromium: 130.0.6723.58 (Official Build) canary (64-bit)
--- | ---
Revision | 4bf64612a0dd37348839ed716b84d65b8263883a
OS | Android 15; Build/AP41.240823.009; 35; REL

Test Case #1 - brave/brave-browser#41591

Using the STR/Cases outlined via brave/brave-browser#41591 (comment), ensured that Country Code - Optimal is being displayed in the Hamburger Menu when Optimal is selected via the server selection as per the following:

  • ensured that Country Code - Optimal is being displayed in the Hamburger Menu when Optimal is selected
  • ensured that the Country Code - Location is being displayed in the Hamburger Menu when a specific server is selected

Optimal Examples

Example Example Example
1000002151 1000002153 1000002158

Specific servers selected Examples

Example Example Example Example
1000002155 1000002154 1000002157 1000002156

Test Case #2 - brave/brave-browser#41592

Using the STR/Cases outlined via brave/brave-browser#41592 (comment), ensured that USA is being used as the main string throughout the different menu's (Hamburger Menu being the exception as we're using XX country codes.

Example Example Example Example
Screenshot_20241017-185915 Screenshot_20241017-185919 Screenshot_20241017-185936 Screenshot_20241017-185954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
4 participants