-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hamburge menu for VPN #26005
Update hamburge menu for VPN #26005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Released in v1.73.14 |
Verification PASSED on
|
Example |
Example |
Example |
---|---|---|
Specific servers selected Examples
Example |
Example |
Example |
Example |
---|---|---|---|
Test Case #2
- brave/brave-browser#41592
Using the STR/Cases outlined via brave/brave-browser#41592 (comment), ensured that USA
is being used as the main string throughout the different menu's (Hamburger Menu
being the exception as we're using XX
country codes.
Example |
Example |
Example |
Example |
---|---|---|---|
Resolves brave/brave-browser#41591
Resolves brave/brave-browser#41592
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
With new update, hamburge menu should like : brave/brave-browser#41591 (comment)