Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide upstream speed settings #25993

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 15, 2024

Resolves brave/brave-browser#41565

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/719b8cd15b7e53209f1d0b1688ac8e96b4845377

commit 719b8cd15b7e53209f1d0b1688ac8e96b4845377
Author: Charles Meng <[email protected]>
Date:   Thu Feb 8 19:40:12 2024 +0000

    Clean up functions for showing performance settings sections

    Previously these functions were checking if feature flags were enabled.
    Now that those feature flags are enabled by default, these functions
    may be replaced by showPage_.

    Bug: 1523807
@emerick emerick requested a review from mkarolin October 15, 2024 13:25
@emerick emerick self-assigned this Oct 15, 2024
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Oct 15, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@emerick emerick merged commit 62dc319 into master Oct 15, 2024
18 checks passed
@emerick emerick deleted the emerick-hide-chrome-speed-settings branch October 15, 2024 17:11
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 15, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Speed" section in Settings from Chromium still visible when searched
3 participants