-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed device duplication when Google Account cookies are deleted #25971
base: master
Are you sure you want to change the base?
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "login" and so security team members have been added as reviewers to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, removing the needs-security-review
label
56f9ed0
to
a4b509c
Compare
chromium_src/components/signin/public/identity_manager/identity_manager.h
Outdated
Show resolved
Hide resolved
chromium_src/components/signin/public/identity_manager/identity_manager.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving as code owner for chromium_src
…t BraveSyncServiceImplGACookiesTest.CacheGuidIsNotWiped/OnPrimaryAccountChanged cleaner
83f3830
to
dc7de33
Compare
This PR disables upstream's methods
to prevent re-creating of
Sync Client ID
and device duplication in a Sync chain.Resolves brave/brave-browser#41615
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
I. Scenario with manual logout from GMail
II. Scenario with
Delete sites data
option