Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves teardown to prevent failing test on Win #25960

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

jonathansampson
Copy link
Contributor

Resolves brave/brave-browser#41605

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add a comment referencing upstream code indicating that this is the fix for this issue.

@jonathansampson jonathansampson force-pushed the sampson-issue-41605-unit-test-teardown-fix branch from 7aef363 to 29776a4 Compare October 17, 2024 19:03
@jonathansampson jonathansampson enabled auto-merge (squash) October 17, 2024 19:04
@jonathansampson jonathansampson merged commit 9c2189d into master Oct 17, 2024
17 checks passed
@jonathansampson jonathansampson deleted the sampson-issue-41605-unit-test-teardown-fix branch October 17, 2024 21:37
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 17, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BraveRenderViewContextMenuTest unit tests failing on Windows
4 participants