Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DanglingPtr] Enable dangling pointer checks #25958

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Oct 13, 2024

This change enables dangling pointer checks, which had been disabled through enable_dangling_raw_ptr_feature_flag. With this flag on, BackRefPtr checks will be checked when running browser tests.

This change additionally tags several pointers as DanglingUntriaged. This will allow us to gradually investigate, and enable dangling pointer checks for these particular pointers.

To run locally:

is_debug = false
is_component_build = false
dcheck_always_on = true

enable_backup_ref_ptr_support=false
is_asan=true
use_asan_backup_ref_ptr=false
use_raw_ptr_asan_unowned_impl=true
enable_backup_ref_ptr_instance_tracer=false

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This change enables dangling pointer checks, which had been disabled
through `enable_dangling_raw_ptr_feature_flag`. With this flag on,
`BackRefPtr` checks will be checked when running browser tests.

This change additionally tags several pointers as `DanglingUntriaged`.
This will allow us to gradually investigate, and enable dangling pointer
checks for these particular pointers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant