Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(privacy): Fix Shred on app close #25954

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

StephenHeaps
Copy link
Collaborator

@StephenHeaps StephenHeaps commented Oct 11, 2024

  • Apple kills the app before we have a chance to shred. Update the Shred on App Close logic to not restore tabs for sites with 'App Close' preference set, and then shred the sites after tab restore.
  • Fix bug causing tabs closed before app is quit to not be Shred on app close.
  • Fix feature flag not correctly wrapping Shed on App Close logic.

Resolves brave/brave-browser#40484

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable Shred feature flag (#brave-shred) in brave://flags
    • Note: 3rd party caches will remain in Manage Website Data without the #brave-shred-cache-data flag enabled
  2. In Shields settings, update 'Auto Shred' preference to 'App Close'
  3. Open a few websites in different tabs
  4. Close one of the tabs (before quitting the app)
    • This will be to verify site data from tabs closed before app is quit are also Shred.
  5. Fully quit the app from iOS app switcher and re-launch
  6. Verify All tabs are closed
    • Note: A site-specific Shred preference can be applied Shields panel when visiting a site
  7. Open 'Settings' -> 'Shields & Privacy' -> 'Manage Site Data'
  8. Verify all 1st party site data is removed
  9. Open 'History'
  10. Verify site(s) are removed from history
  11. Open a few websites in different tabs
  12. In one of the tabs, open shields panel, tap 'Advanced controls' and tap 'Shred Site Data'.
  13. Change site preference to 'Never'
  14. Fully quit the app from iOS app switcher and re-launch
  15. Verify all tabs are closed except the site manually changed to 'Never'
  16. Open 'Settings' -> 'Shields & Privacy' -> 'Manage Site Data'
  17. Verify all 1st party site data is removed except the site manually changed to 'Never'
  18. Open 'History'
  19. Verify site(s) are removed from history
  20. Do a quick pass with 'Auto Shred' set to 'Site Tabs Closed' (Shred is delayed 30 seconds after tab close in this case)

@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 11, 2024
@StephenHeaps StephenHeaps self-assigned this Oct 11, 2024
@StephenHeaps StephenHeaps marked this pull request as ready for review October 15, 2024 14:19
@StephenHeaps StephenHeaps requested a review from a team as a code owner October 15, 2024 14:19
@StephenHeaps StephenHeaps merged commit 7a94ba9 into master Oct 17, 2024
17 checks passed
@StephenHeaps StephenHeaps deleted the bugfix/shred-app-close branch October 17, 2024 19:10
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 17, 2024
brave-builds added a commit that referenced this pull request Oct 17, 2024
brave-builds added a commit that referenced this pull request Oct 17, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Shred] Tab and data not deleted when using 'App Close' for Auto Shred
4 participants