Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placement of inactive tabs setting #25952

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 11, 2024

Resolves brave/brave-browser#41576

Screenshot 2024-10-11 103035

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@emerick emerick merged commit a4ea608 into master Oct 11, 2024
18 checks passed
@emerick emerick deleted the cr130-followup-fix-inactive-tabs-setting-placement branch October 11, 2024 16:30
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 11, 2024
emerick added a commit that referenced this pull request Oct 11, 2024
…-setting-placement

Fix placement of inactive tabs setting
emerick added a commit that referenced this pull request Oct 11, 2024
…-setting-placement

Fix placement of inactive tabs setting
@brave-builds
Copy link
Collaborator

Released in v1.73.8

@LaurenWags
Copy link
Member

LaurenWags commented Oct 14, 2024

Verified with

Brave | 1.73.8 Chromium: 130.0.6723.44 (Official Build) nightly (x86_64)
-- | --
Revision | 4a7f8108cbec77e83d990736f4f4a76d4f822c4f
OS | macOS Version 14.7 (Build 23H124)

Verified STR from brave/brave-browser#41576 (comment):

  • Confirmed "Inactive tabs appearance" is displayed at the bottom of the "Tabs" section of brave://settings/appearance
  • Confirmed that there's a separator between "Show memory usage on tab hover preview card" and "Inactive tabs appearance" that is visible on both light and dark theme
Dark Light
Screenshot 2024-10-14 at 8 46 37 AM Screenshot 2024-10-14 at 8 46 50 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change location of "Inactive tabs appearance" setting and add separator
4 participants