Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update laptop icon for sync #25939

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update laptop icon for sync #25939

merged 1 commit into from
Oct 10, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Oct 10, 2024

Resolves brave/brave-browser#40936

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Have a sync group with a Desktop, Android, iOS, and a tablet (iOS or Android) in the sync group
  2. Be on Android and go to Settings > Sync
  3. Look at the devices on sync chain
    • Desktop ones should be showing the Laptop icon
    • iOS and Android ones should be showing the Mobile icon
    • Tablets should be showing the tablet icon

Resolve presubmit issue
@deeppandya deeppandya added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Oct 10, 2024
@deeppandya deeppandya added this to the 1.73.x - Nightly milestone Oct 10, 2024
@deeppandya deeppandya self-assigned this Oct 10, 2024
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@deeppandya deeppandya merged commit 1312783 into master Oct 10, 2024
18 checks passed
@deeppandya deeppandya deleted the update_laptop_icon_sync branch October 10, 2024 23:09
@brave-builds
Copy link
Collaborator

Released in v1.73.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Replace desktop icon with laptop icon for desktop/laptop device
3 participants