Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace requests to laptop-updates.brave.com with requests to usage-ping.brave.com and feedback.brave.com #25920

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace requests to laptop-updates.brave.com with requests to usage-ping.brave.com and feedback.brave.com #25920

wants to merge 1 commit into from
+35 −28

Conversation

DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#16374

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries requested review from a team and simonhong as code owners October 10, 2024 05:42
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Oct 10, 2024
@DJAndries DJAndries force-pushed the replace-laptop-updates branch 2 times, most recently from 3bd8f97 to 7fcc59d Compare October 10, 2024 18:50
@DJAndries DJAndries requested a review from a team as a code owner October 10, 2024 21:41
petemill
petemill reviewed Oct 15, 2024
View reviewed changes
components/brave_referrals/browser/brave_referrals_service.cc Outdated
referral_server = kBraveReferralsServer;
if (env->HasVar("BRAVE_REFERRALS_LOCAL"))
proto = "http";
referral_server = BUILDFLAG(BRAVE_REFERRALS_SERVER);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding another build flag variable for the referrals server, couldn't this use the existing brave_domains::GetServicesDomain(string key) function, which will take a prefix ("usage-ping" or "referrals" in this case) and add the correct domain suffix according to the build environment or cli param overrides.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, i forgot about that function. let me swap that out.

@DJAndries DJAndries changed the base branch from master to add-ping-url-to-list October 15, 2024 23:49
Base automatically changed from add-ping-url-to-list to master October 16, 2024 02:04
@DJAndries DJAndries force-pushed the replace-laptop-updates branch 2 times, most recently from 1e14eff to 50d9b1b Compare October 16, 2024 19:16
bridiver
bridiver reviewed Oct 17, 2024
View reviewed changes
ios/brave-ios/Sources/Growth/DAU.swift
@@ -20,8 +20,8 @@ public class DAU {
// TODO: Handle via brave-stats-updater-server switch and get URL from brave_stats_updater_url
let domain =
AppConstants.isOfficialBuild
? "https://laptop-updates.brave.com/"
: "https://laptop-updates.bravesoftware.com/"
? "https://usage-ping.brave.com/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylehickinson @Brandon-T we should export BraveServicesDomain to ios

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also hard-coding these url defeats the purpose of not including them in the gn config by default

mihaiplesa
mihaiplesa reviewed Oct 17, 2024
View reviewed changes
android/BUILD.gn Outdated Show resolved Hide resolved
@DJAndries
Replace requests to laptop-updates.brave.com with requests to `usag…
02d588f 
…e-ping.brave.com` and `feedback.brave.com`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

@petemill petemill petemill left review comments

@mihaiplesa mihaiplesa mihaiplesa left review comments

@fmarier fmarier fmarier approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

@iefremov iefremov iefremov approved these changes

@simonhong simonhong simonhong approved these changes

Assignees

@DJAndries DJAndries

Labels
CI/run-network-audit Run network-audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the laptop-updates.brave.com endpoint
8 participants
@DJAndries @bridiver @fmarier @kylehickinson @petemill @mihaiplesa @iefremov @simonhong