Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI Chat] positions cursor at end of input when editing #25831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonathansampson
Copy link
Contributor

@jonathansampson jonathansampson commented Oct 6, 2024

When the user indicates they would like to edit a previous message, we will position the cursor at the end of their previous input.

Resolves brave/brave-browser#41176

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

(From the original issue):

  1. Launch Brave
  2. Open Leo
  3. Send a prompt
  4. Tap Pencil to edit the prompt > Observe

@jonathansampson jonathansampson added release-notes/exclude feature/leo Leo-related issues and features labels Oct 6, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 6, 2024
@jonathansampson jonathansampson marked this pull request as ready for review October 6, 2024 01:54
When the user indicates they would like to edit a previous message, we will position the cursor at the end of their previous input.
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@jonathansampson jonathansampson enabled auto-merge (squash) October 17, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/leo Leo-related issues and features release-notes/exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointer/Cursor must be shown at the end of the string when opening the Edit prompt
2 participants