-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BYOM] Moves page-content to own entry #25807
Conversation
Rebasing to resolve chromium-version-mismatch. |
23c1465
to
1ddc29d
Compare
@jonathansampson does it work also for custom messages (non-summary) while using the page context? |
Sorry, can you elaborate on the scenario? Not sure I fully understand. |
Instead of clicking |
Yes, regular chat messages also work when page content is included. |
By moving the page_content to its own conversation entry, we prevent the chat history within Leo from being inundated with distilled content for BYOM users.
Now that page summaries are in their own conversation turn, we need to adjust the indexes we check in the SummarizePage test.
1ddc29d
to
aa38d53
Compare
Released in v1.73.23 |
By moving the page_content to its own conversation entry, we prevent the chat history within Leo from being inundated with distilled content for BYOM users. This approach was verified to work with both a local Ollama instance, and also with ChatGPT.
Resolves brave/brave-browser#41079
Left: Currently Nightly showing backfilled page content into chat history.
Right: Local build with suggested changes showing no backfilling.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: