Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOM] Moves page-content to own entry #25807

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

jonathansampson
Copy link
Contributor

@jonathansampson jonathansampson commented Oct 3, 2024

By moving the page_content to its own conversation entry, we prevent the chat history within Leo from being inundated with distilled content for BYOM users. This approach was verified to work with both a local Ollama instance, and also with ChatGPT.

Resolves brave/brave-browser#41079

Left: Currently Nightly showing backfilled page content into chat history.
Right: Local build with suggested changes showing no backfilling.

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Visit https://sampson.codes/ua
  2. Open Leo, and select a custom model
  3. Click "Summarize this page"
  4. Verify that the page summary is not added to the visible prompt

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 3, 2024
@jonathansampson jonathansampson changed the title moves page-content to own entry [AI Chat] moves page-content to own entry Oct 3, 2024
@jonathansampson
Copy link
Contributor Author

Rebasing to resolve chromium-version-mismatch.

@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 3, 2024
@jonathansampson jonathansampson added bug release-notes/exclude feature/leo Leo-related issues and features labels Oct 4, 2024
@jonathansampson jonathansampson marked this pull request as ready for review October 4, 2024 19:41
@LorenzoMinto
Copy link
Member

@jonathansampson does it work also for custom messages (non-summary) while using the page context?

@jonathansampson
Copy link
Contributor Author

@jonathansampson does it work also for custom messages (non-summary) while using the page context?

Sorry, can you elaborate on the scenario? Not sure I fully understand.

@LorenzoMinto LorenzoMinto changed the title [AI Chat] moves page-content to own entry [BYOM] Moves page-content to own entry Oct 7, 2024
@LorenzoMinto
Copy link
Member

Instead of clicking Summarise this page you ask a free-text question in the input box

@jonathansampson
Copy link
Contributor Author

Instead of clicking Summarise this page you ask a free-text question in the input box

Yes, regular chat messages also work when page content is included.

By moving the page_content to its own conversation entry, we prevent the chat history within Leo from being inundated with distilled content for BYOM users.
Now that page summaries are in their own conversation turn, we need to adjust the indexes we check in the SummarizePage test.
@jonathansampson jonathansampson enabled auto-merge (squash) October 17, 2024 18:54
@jonathansampson jonathansampson merged commit 264a092 into master Oct 17, 2024
17 checks passed
@jonathansampson jonathansampson deleted the sampson-issue-41079 branch October 17, 2024 20:53
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 17, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/leo Leo-related issues and features release-notes/exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BYOM] Unintended Prompt Backfilling into Chat History
5 participants