Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade storybook to 8.3.5 #25794

Merged
merged 1 commit into from
Oct 15, 2024
Merged

upgrade storybook to 8.3.5 #25794

merged 1 commit into from
Oct 15, 2024

Conversation

petemill
Copy link
Member

@petemill petemill commented Oct 3, 2024 •
edited
Loading

Minor bump, helps resolve some audit dependency update from #26007

Fix brave/brave-browser#41654

@petemill petemill self-assigned this Oct 3, 2024
@petemill petemill requested a review from a team as a code owner October 3, 2024 04:56
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Oct 3, 2024
fallaciousreasoning
fallaciousreasoning approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I was scared when I saw
image

@fallaciousreasoning fallaciousreasoning added dev/storybook CI/storybook-url Deploy storybook and provide a unique URL for each build labels Oct 3, 2024
@diracdeltas
Copy link
Member

diracdeltas commented Oct 15, 2024 •
edited
Loading

@petemill any update here? i think it's blocking #26007 (though maybe that requires 8.3.5)

@petemill petemill changed the title upgrade storybook to 8.3.4 upgrade storybook to 8.3.5 Oct 15, 2024
@petemill petemill added the dependencies Pull requests that update a dependency file label Oct 15, 2024
@petemill petemill enabled auto-merge (squash) October 15, 2024 19:38
@petemill petemill merged commit 0d79285 into master Oct 15, 2024
17 checks passed
@petemill petemill deleted the storybook-8-3 branch October 15, 2024 21:24
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 15, 2024
@petemill petemill mentioned this pull request Oct 15, 2024
Closed
brave-builds added a commit that referenced this pull request Oct 15, 2024
@brave-builds
Uplift of #25794 (squashed) to beta
790baf3
brave-builds added a commit that referenced this pull request Oct 15, 2024
@brave-builds
Uplift of #25794 (squashed) to release
0c66442
This was referenced Oct 15, 2024
Merged
Merged
@brave-builds
Copy link
Collaborator

Released in v1.73.14

kjozwiak pushed a commit that referenced this pull request Oct 16, 2024
@brave-builds
upgrade storybook to 8.3.5 (uplift to 1.72.x) (#26019)
350dd83 
Uplift of #25794 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Oct 16, 2024
@brave-builds
upgrade storybook to 8.3.5 (uplift to 1.71.x) (#26020)
5363cd1 
Uplift of #25794 (squashed) to release
diracdeltas pushed a commit that referenced this pull request Oct 17, 2024
@petemill @diracdeltas
upgrade storybook to 8.3.5 (#25794)
fb48956
kjozwiak pushed a commit that referenced this pull request Oct 17, 2024
@diracdeltas @petemill
upgrade storybook to 8.3.5 (#25794) - uplift to 1.70.x (#26054)
b07b6cf 
upgrade storybook to 8.3.5 (#25794)

Co-authored-by: Pete Miller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas approved these changes

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

Assignees

@petemill petemill

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build dependencies Pull requests that update a dependency file dev/storybook
Projects
None yet
Milestone
1.73.x - Nightly
Development

Successfully merging this pull request may close these issues.

Storybook minor dependency update to 8.3.5
4 participants
@petemill @diracdeltas @brave-builds @fallaciousreasoning