Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SidePanel: fixes button pressed state. #25679

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Sep 20, 2024

Resolves brave/brave-browser#41154

It's a regression that only SidebarContainerView::OnRegistryDestroyig() is called when active tab with ai chat is closed now.
Instead, we could try to make sidebar controller refresh active item state whenever relavant event happens.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue for manual test.
SidebarBrowserTestWithAIChat.TabSpecificPanel

@mkarolin mkarolin self-assigned this Sep 20, 2024
@mkarolin
Copy link
Collaborator Author

cc: @simonhong, please let me know what you think.

@simonhong
Copy link
Member

@mkarolin Added my changes. PTAL :)

@simonhong simonhong force-pushed the maxk-side-panel-fixes branch 3 times, most recently from 642a10f to eae9f26 Compare September 30, 2024 13:13
@mkarolin
Copy link
Collaborator Author

Seems to work well. Thank you @simonhong

@mkarolin mkarolin marked this pull request as ready for review September 30, 2024 15:11
@mkarolin mkarolin requested review from petemill and removed request for simonhong September 30, 2024 15:11
@mkarolin mkarolin removed their assignment Oct 1, 2024
@simonhong
Copy link
Member

@petemill Kindly ping :)

@simonhong
Copy link
Member

simonhong commented Oct 4, 2024

SidebarBrowserTestWithAIChat.TabSpecificPanel failed after cr130 bump. checking.
Set as draft as this PR doesn't work with cr130.
Fixed.

@simonhong simonhong marked this pull request as draft October 4, 2024 06:15
@simonhong simonhong marked this pull request as ready for review October 4, 2024 08:31
mkarolin and others added 2 commits October 10, 2024 16:39
Fixes pressed state for side panel action buttons when performing
actions on tabs (adding/deleting/switching).
As contextual registry is owned by TabFeatures, that registry is destroyed
before coordinator notifies OnEntryHidden() when tab is closed.
In this case, we should update sidebar ui(active item state)
with this notification. If not, sidebar ui's active item state is not
changed.
@simonhong simonhong merged commit fd01fe9 into master Oct 11, 2024
17 checks passed
@simonhong simonhong deleted the maxk-side-panel-fixes branch October 11, 2024 00:23
@github-actions github-actions bot added this to the 1.73.x - Nightly milestone Oct 11, 2024
brave-builds added a commit that referenced this pull request Oct 11, 2024
@brave-builds
Copy link
Collaborator

Released in v1.73.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leo panel stuck in open state
4 participants