-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SidePanel: fixes button pressed state. #25679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc: @simonhong, please let me know what you think. |
simonhong
force-pushed
the
maxk-side-panel-fixes
branch
from
September 30, 2024 10:50
c47552c
to
d39b249
Compare
@mkarolin Added my changes. PTAL :) |
simonhong
force-pushed
the
maxk-side-panel-fixes
branch
3 times, most recently
from
September 30, 2024 13:13
642a10f
to
eae9f26
Compare
Seems to work well. Thank you @simonhong |
6 tasks
@petemill Kindly ping :) |
simonhong
force-pushed
the
maxk-side-panel-fixes
branch
from
October 4, 2024 01:25
eae9f26
to
83a4ef6
Compare
|
simonhong
force-pushed
the
maxk-side-panel-fixes
branch
from
October 4, 2024 08:30
83a4ef6
to
839e32a
Compare
Fixes pressed state for side panel action buttons when performing actions on tabs (adding/deleting/switching).
As contextual registry is owned by TabFeatures, that registry is destroyed before coordinator notifies OnEntryHidden() when tab is closed. In this case, we should update sidebar ui(active item state) with this notification. If not, sidebar ui's active item state is not changed.
simonhong
force-pushed
the
maxk-side-panel-fixes
branch
from
October 10, 2024 07:51
839e32a
to
2ad82ab
Compare
petemill
approved these changes
Oct 10, 2024
7 tasks
simonhong
pushed a commit
that referenced
this pull request
Oct 11, 2024
Released in v1.73.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#41154
It's a regression that only
SidebarContainerView::OnRegistryDestroyig()
is called when active tab with ai chat is closed now.Instead, we could try to make sidebar controller refresh active item state whenever relavant event happens.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See the linked issue for manual test.
SidebarBrowserTestWithAIChat.TabSpecificPanel