-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] - Fix VPN subscriptions ignoring empty transactions states #25560
Conversation
self.delegate?.purchaseFailed( | ||
error: .transactionError(error: transaction.error as? SKError) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you not need to check callPurchaseDelegateOnce
for the failure case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
case .failed: | ||
Logger.module.debug("Received transaction state: failed") | ||
|
||
if !callPurchaseDelegateOnce { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is backwards, should be if callPurchaseDelegateOnce
49928b2
to
70f0a51
Compare
70f0a51
to
45931e1
Compare
45931e1
to
dc3fdbb
Compare
Add call once check for failure cases. Fix boolean logic
dc3fdbb
to
5745921
Compare
Released in v1.73.23 |
Summary
Resolves brave/brave-browser#41012
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: