-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet) Implement Meld Buy Flow in the FE #25088
base: master
Are you sure you want to change the base?
Conversation
61d1c01
to
68e56e0
Compare
A Storybook has been deployed to preview UI for the latest push |
68e56e0
to
1b16ab2
Compare
d30ef89
to
ee5e4ae
Compare
A Storybook has been deployed to preview UI for the latest push |
c1c099c
to
e7384ee
Compare
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
core++
e7384ee
to
58cebd0
Compare
ad2dbd4
to
c9113e8
Compare
c9113e8
to
6148dd0
Compare
e91daaa
to
a9f2605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
A Storybook has been deployed to preview UI for the latest push |
efb6f3a
to
3b8bfc2
Compare
3b8bfc2
to
67298b0
Compare
[puLL-Merge] - brave/brave-core@25088 DescriptionThis PR introduces significant changes to the Brave Wallet UI, particularly focusing on the Fund Wallet feature. It adds new components, refactors existing ones, and introduces integration with Meld.io for crypto transactions. Possible Issues
Security Hotspots
ChangesChanges
This PR represents a significant update to the Brave Wallet UI, particularly in the Fund Wallet feature, with new integrations and UI components. |
Description
Introduces a new
Buy Crypto
flow usingMeld
API's in theBrave Wallet
.User are now able to get realtime
Quotes
from multiple providers with more assets to choose from.Resolves brave/brave-browser#38985
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Wallet
and navigate to theBuy
screenEthereum
should be automatically pre-selected and should fetchquotes
tokens
, changingaccount
and changingcurrencies
Payment Methods
Portfolio
page and click theMore Menu
for a token, ifBuy
is available for that token you should see aBuy
button and it should pre populate theToken
and properAccount
after clicking.Screen.Recording.6.mov