[Uplift 1.62] [Brave News]: Build feed off the main thread (#21833) #22044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fallaciousreasoning
commented
Feb 14, 2024
•
fallaciousreasoning
commented
- Uplift of [Brave News]: Build feed off the main thread #21833
- Resolves [Perf] Fix JSON processing on UI thread brave-browser#35695
kjozwiak
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Closing as discussed via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1707869423133049. As mentioned by @atuchin-m, the above performance fix touches ~1/2 of the features within Brave even though it's a small fix. We'll uplift the above into 1.63.x as that's right around the corner. It will have some time to bake within 1.63.x and will also get verified by default when QA starts running through the manual passes once we merge C122 into 1.63.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.