Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet): fix signing of Solana transactions with Ledger (uplift to 1.62.x) #21902

Merged
merged 2 commits into from
Feb 6, 2024
Merged

fix(wallet): fix signing of Solana transactions with Ledger (uplift to 1.62.x) #21902

merged 2 commits into from
Feb 6, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 5, 2024 •
edited by kjozwiak
Loading

Uplift of #21894
Resolves brave/brave-browser#35802

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 5, 2024 15:54
@brave-builds brave-builds added this to the 1.62.x - Release #4 milestone Feb 5, 2024
@brave-builds brave-builds self-assigned this Feb 5, 2024
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Feb 5, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@onyb onyb self-assigned this Feb 6, 2024
kjozwiak
kjozwiak approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.62.x approved 👍 QA has verified the PR on Nightly using 1.64.x as per #21894 (comment).

@kjozwiak kjozwiak merged commit dcb6045 into 1.62.x Feb 6, 2024
13 checks passed
@kjozwiak kjozwiak deleted the pr21894_f/wallet/fix-sol-ledger-sign_1.62.x branch February 6, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@onyb onyb

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Milestone
1.62.x - Release #4
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @onyb