Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable FeedV2 feature by default #21579

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Disable FeedV2 feature by default #21579

merged 1 commit into from
Jan 19, 2024

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#35317

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. When opening Brave 1.62.x for the first time we should display the old feed

@kjozwiak
Copy link
Member

We'll need to wait till 1.62.x goes into Release once we do channel migrations on Jan. 17th. This way, the News v2 Feed will be enabled on 1.63.x (BETA) & 1.64.x (Nightly) while being disabled on 1.62.x. Once 1.62.x is released, we'll enable the feature using Griffin and slowly roll it out through the week.

@fallaciousreasoning
Copy link
Contributor Author

@kjozwiak now we've branched, can we land this?

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjozwiak now we've branched, can we land this?

yup, uplift into 1.62.x approved 👍

@kjozwiak kjozwiak merged commit 4ff0045 into 1.62.x Jan 19, 2024
15 checks passed
@kjozwiak kjozwiak deleted the bn-flag-off branch January 19, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants