Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parallel import #15674

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Added parallel import #15674

merged 5 commits into from
Nov 1, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 26, 2022

Resolves brave/brave-browser#26282

For new onboarding brave/brave-browser#26378 we have to be able to run imports from multiple browsers with one click. Chromium has single import implementation and we added opportunity to run multiple imports simultaneously.

  • Moved mac CheckDisk to BUILDFLAGs inside BraveImportDataHandler instead of separate file to be able to run new import.
  • Moved FullDiskAccessConfirmDialogDelegate to separate files, NO CHANGES inside.
  • Added a new event brave-import-data-status-changed with detailed information about the progress.
  • Added kParallelImports feature to disable new code until Update onboarding to new design and flow brave-browser#26378 landed, because it is not compatible with old way and replaces it. @nullhook will remove this flag and enable new code in that PR.

IMPORTANT!: New code is disabled now by kParallelImports feature flag, it will be enabled by @nullhook in his PR brave/brave-browser#26378.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Check imports on mac and win, should work as expected.
  • Pay attention to Check disc permission feature for mac, should work as expected

@spylogsster spylogsster self-assigned this Oct 26, 2022
@spylogsster spylogsster changed the title Added parallel import wip: Added parallel import Oct 26, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Oct 26, 2022
@spylogsster spylogsster force-pushed the parallel-import branch 4 times, most recently from 9b561d6 to 50ca195 Compare October 26, 2022 18:38
@spylogsster spylogsster force-pushed the parallel-import branch 7 times, most recently from a410be0 to d76b831 Compare October 29, 2022 16:22
@spylogsster spylogsster marked this pull request as ready for review October 29, 2022 16:34
@spylogsster spylogsster changed the title wip: Added parallel import Added parallel import Oct 29, 2022
@spylogsster spylogsster force-pushed the parallel-import branch 2 times, most recently from 65f8c60 to acf34fd Compare October 29, 2022 16:52
@spylogsster spylogsster force-pushed the parallel-import branch 5 times, most recently from 27cdd40 to 9f5420c Compare October 31, 2022 16:14
@nullhook nullhook mentioned this pull request Oct 31, 2022
25 tasks
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ with some nits! 👍🏼

@spylogsster spylogsster merged commit 45904ff into master Nov 1, 2022
@spylogsster spylogsster deleted the parallel-import branch November 1, 2022 10:52
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to import multiple profiles in parallel
2 participants