-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chrono
crate
#44035
Closed
Comments
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Feb 17, 2025
This PR updates `chrono` to version `0.4.39`. This is one of the steps to eventually allow dropping `[email protected]`. Updating this crate has run into issues with the list `remove_crates` in `gnrt_config.toml`, which had to be updated to better match the upstream version. Addional changes were necessary to correct failures around license file paths for some of the crates affected. Resolves brave/brave-browser#44035
24 tasks
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Feb 18, 2025
This PR updates `chrono` to version `0.4.39`. This is one of the steps to eventually allow dropping `[email protected]`. Updating this crate has run into issues with the list `remove_crates` in `gnrt_config.toml`, which had to be updated to better match the upstream version. Addional changes were necessary to correct failures around license file paths for some of the crates affected. Resolves brave/brave-browser#44035
cdesouza-chromium
added a commit
to brave/brave-core
that referenced
this issue
Feb 19, 2025
This PR updates `chrono` to version `0.4.39`. This is one of the steps to eventually allow dropping `[email protected]`. Updating this crate has run into issues with the list `remove_crates` in `gnrt_config.toml`, which had to be updated to better match the upstream version. Addional changes were necessary to correct failures around license file paths for some of the crates affected. Resolves brave/brave-browser#44035
kdenhartog
pushed a commit
to brave/brave-core
that referenced
this issue
Feb 19, 2025
* [CodeHealth][rust] Update `chrono-0.4.24` => `chrono-0.4.39` This PR updates `chrono` to version `0.4.39`. This is one of the steps to eventually allow dropping `[email protected]`. Updating this crate has run into issues with the list `remove_crates` in `gnrt_config.toml`, which had to be updated to better match the upstream version. Addional changes were necessary to correct failures around license file paths for some of the crates affected. Resolves brave/brave-browser#44035 * [CodeHealth][rust] Update `remove_crates` list with upstream This list was not entirely matching the upstream one, which at first was not a problem, but this has run into issues running `gnrt gen` once `chrono` was updated. This change adds the missing `windows_*` crates that belong to that list to the brave file. * [CodeHealth][rust] Using a common `Apache-2.0` for some crates For some reason some of these crates are trying to set the path for the license file under `//brave`, rather than on the source. This change redirects the license file to the common `Apache-2.0` license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This crate is one of the reasons for us to be still using the older version of
windows-targets
The text was updated successfully, but these errors were encountered: