Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passwords are wiped on Android on cr132 #43171

Closed
2 of 6 tasks
AlexeyBarabash opened this issue Jan 8, 2025 · 3 comments · Fixed by brave/brave-core#27191
Closed
2 of 6 tasks

Passwords are wiped on Android on cr132 #43171

AlexeyBarabash opened this issue Jan 8, 2025 · 3 comments · Fixed by brave/brave-core#27191
Assignees
@AlexeyBarabash
Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release/blocking release-notes/exclude
Milestone
1.74.x - Release

Comments

@AlexeyBarabash
Copy link
Contributor

AlexeyBarabash commented Jan 8, 2025 •
edited
Loading

Description

There are two sides of the bug.

I. Passwords are not saved on Android if the Sync is not turned on.

Steps to reproduce

  1. Take fresh install, I used 1.75.151
  2. Ensure the sync is turned off
  3. Login to some site, save the password when will be prompted
  4. Go to Settings => Brave Password Manager, ensure the password is there
  5. Restart browser
  6. Go again to Settings => Brave Password Manager

Actual result

  1. There is no saved password

Expected result

  1. The saved password should persist

II. Existing passwords are wiped on Android if the Sync is not turned on when upgrading from cr131 to cr132.

Steps to reproduce

  1. Take fresh install of the version based on cr131, I used v1.75.66
  2. Ensure the sync is turned off
  3. Login to some site, save the password when will be prompted
  4. Go to Settings => Brave Password Manager, ensure the password is there
  5. Update browser to the version of cr132, I used v1.76.9
  6. Launch browser
  7. Go again to Settings => Brave Password Manager

Actual result

  1. There is no saved password

Expected result

  1. The saved password should persist

Reproduces how often

Easily reproduced

Brave version

1.75.151

Device

  • Brand/model: Samsung s22
  • Android version: 14

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

When Sync of the passwords is on - the issue is not reproduced.
@AlexeyBarabash AlexeyBarabash added bug OS/Android Fixes related to Android browser functionality labels Jan 8, 2025
@AlexeyBarabash AlexeyBarabash self-assigned this Jan 8, 2025
@AlexeyBarabash AlexeyBarabash added priority/P2 A bad problem. We might uplift this to the next planned release. release/blocking labels Jan 8, 2025
@kjozwiak kjozwiak added this to the 1.74.x - Release milestone Jan 9, 2025
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jan 10, 2025
@AlexeyBarabash
[Android] Prevent wiping passwords on cr132; fixes brave/brave-browse…
d61c3d2 
…r#43171
@AlexeyBarabash AlexeyBarabash mentioned this issue Jan 10, 2025
Merged
24 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jan 13, 2025
@AlexeyBarabash
[Android] Prevent wiping passwords on cr132; fixes brave/brave-browse…
e22cfc1 
…r#43171

Related Chromium changes:

https://source.chromium.org/chromium/chromium/src/+/9dd58ffaeed73e9e1f9594e8a7f36dd0d5add9ba

	[UPMClearMigratedData] Enable feature by default

	And correct some outdated tests.

	Bug: 350509489
	Change-Id: I148ddd636c5421bb01345d53bb6b32b557066ba5
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5975566

	Committed on 2024-10-30 4:46 PM

https://source.chromium.org/chromium/chromium/src/+/2bd4e38dc9ed39d922061a54b06d586528f33f7e

	[UPMLoginDbSunset] Clean up ClearLoginDatabaseForAllMigratedUPMUsers

	.. after launch. This was enabled by default in crrev.com/c/5975566.

	Bug: 381113374
	Change-Id: I606f036fd2d090af1aee7a2715911cc04926ca74
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054617

	Committed on 2024-12-03 6:55 PM
@AlexeyBarabash AlexeyBarabash changed the title Passwords are not saved Passwords are wiped on Android on cr132 Jan 13, 2025
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Jan 13, 2025
@AlexeyBarabash
[Android] Prevent wiping passwords on cr132; fixes brave/brave-browse…
e653676 
…r#43171

Related Chromium changes:

https://source.chromium.org/chromium/chromium/src/+/9dd58ffaeed73e9e1f9594e8a7f36dd0d5add9ba

	[UPMClearMigratedData] Enable feature by default

	And correct some outdated tests.

	Bug: 350509489
	Change-Id: I148ddd636c5421bb01345d53bb6b32b557066ba5
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5975566

	Committed on 2024-10-30 4:46 PM

https://source.chromium.org/chromium/chromium/src/+/2bd4e38dc9ed39d922061a54b06d586528f33f7e

	[UPMLoginDbSunset] Clean up ClearLoginDatabaseForAllMigratedUPMUsers

	.. after launch. This was enabled by default in crrev.com/c/5975566.

	Bug: 381113374
	Change-Id: I606f036fd2d090af1aee7a2715911cc04926ca74
	Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6054617

	Committed on 2024-12-03 6:55 PM
This was referenced Jan 14, 2025
Merged
Merged
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 14, 2025
@hffvld hffvld removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 14, 2025
@kjozwiak
Copy link
Member

The above requires 1.74.48 or higher for 1.74.x verification 👍

@AlexeyBarabash AlexeyBarabash mentioned this issue Jan 15, 2025
Closed
6 tasks
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.74.48 Chromium: 132.0.6834.83 (Official Build) (64-bit) 
Revision	abcdb1e011a32c5baf82019bf0b537c22baeb92d
OS	Android 13; Build/TP1A.220624.014; 33; REL

Image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.74.48 Chromium: 132.0.6834.83 (Official Build) (64-bit) 
Revision	abcdb1e011a32c5baf82019bf0b537c22baeb92d
OS	Android 13; Build/TP1A.220624.014; 33; REL

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.74.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Prevent wiping passwords on cr132 brave/brave-core
4 participants
@kjozwiak @Uni-verse @AlexeyBarabash @hffvld