[Sync] Passwords are not synced from Android to Desktop

[AlexeyBarabash]

Description

Passwords are not synced from Android to Desktop, but are synced in opposite direction, from Desktop to Android.

Reproduced on version based on cr131 and cr132.

Steps to reproduce

1. Create sync chain with Android and Desktop, enable passwords syncing
2. Login to some site on Desktop, save password
3. Ensure the password is synced to Android
4. Login to some other site on Android, save password

Actual result

5. Actual the password from Android is not synced to Desktop

Expected result

5. Expected the password from Android is synced to Desktop

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

At least any version containing on cr131/cr132. I saw it on 1.76.14 and v1.75.66

Android device

Doesn't matter.

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

Related to Chromium migration from local passwords store to Google account.

Related issues are also:
#43171
#43296

[kjozwiak]

The above requires 1.74.51 or higher for 1.74.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.74.51 Chromium: 132.0.6834.160 (Official Build) (64-bit)
-- | --
Revision | ec533795e8d43cd81dd0c0cff9ed1dbf23d930e2
OS | Windows 10 Version 22H2 (Build 19045.5371)

• Verified the test plan from [Android][Sync] Sync passwords from Android to Desktop brave-core#27271
• Confirmed that the saved password on Desktop synced to Android under Brave password manager
• Confirmed that the saved password on Android synced to Desktop under brave://password-manager/passwords

Devices in sync_PASSED

Desktop	Password sync settings	Android	Password sync settings

Confirmed that Passwords saved on both the devices

Desktop	Android

[hffvld]

Verified on Pixel 6, Galaxy Tab S8 and Desktop/MacOS using version(s):

Device/OS: 
- Pixel 6 / oriole-user 15 AP4A.241205.013 release-keys
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.74.51 
Chromium: 132.0.6834.160 (Official Build) (64-bit) 

---

Fresh install

STEPS:

1. Follow the STR/TP from [Android][Sync] Sync passwords from Android to Desktop brave-core#27271 (comment) and [Sync] Passwords are not synced from Android to Desktop #43303 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that passwords that existed before creating the sync chain are synced between Desktop and Android after creating the sync chain.
• Verified that newly saved passwords are synced between Desktop and Android when both devices are already in the sync chain.
• Verified that deleting the device from the sync chain is not causing passwords to be deleted; reading the device to the sync chain is not causing any problems as well.

---

2025-01-29_13-09-31.mp4

Upgraded profile

STEPS:

1. Install Brave 1.73.100 (where passwords are not synced and removed) on Android
2. Login to some site > Save the password
3. On Desktop go to some site > Save the password
4. Create a sync chain and enable Password syncing on both devices
5. Observe that Android passwords are not shown on Desktop - issue
6. Upgrade Brave on Android to 1.74.51
7. Go to Password Manager on both devices > Verify that all passwords are shown on both devices
8. Remove Android device from the sync chain > Verify that passwords are not removed from any of these devices

ACTUAL RESULTS:

• Verified that all old and newly saved passwords are synced between Desktop and Android after upgrading Brave from 1.73.100 to 1.74.51
• Verified that passwords are not removed from Desktop or Android after removing the Android device from the sync chain.

---

Pixel 6

2025-01-29_12-41-13.mp4

Galaxy Tab S8

2025-01-29_13-29-05.mp4