Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VPN widget to NTP #41778

Closed
simonhong opened this issue Oct 22, 2024 · 0 comments · Fixed by brave/brave-core#26189
Closed

Add VPN widget to NTP #41778

simonhong opened this issue Oct 22, 2024 · 0 comments · Fixed by brave/brave-core#26189
Assignees
@simonhong
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/vpn OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include
Milestone
1.75.x - Nightly

Comments

@simonhong
Copy link
Member

simonhong commented Oct 22, 2024 •
edited
Loading

Captured some images from below figma

vpn purchased vpn purchased

figma - https://www.figma.com/design/cpUWWHUsMtyQHWAES24Kjx/VPN-Widget-BT24?node-id=0-1&node-type=canvas&t=dMgPpDsUQTUb90PY-0

demo code at BT24 - https://github.com/brave/brave-core/tree/brave_vpn_ntp_widget_demo

cc @rebron @bsclifton @w0ts0n @AlanBreck
@simonhong simonhong added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/vpn QA/Yes release-notes/include labels Oct 22, 2024
@simonhong simonhong self-assigned this Oct 22, 2024
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 22, 2024
@simonhong simonhong mentioned this issue Oct 24, 2024
Merged
28 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 10, 2024
This was referenced Nov 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/vpn OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include
Projects
None yet
Milestone
1.75.x - Nightly
Development

Successfully merging a pull request may close this issue.

Brave VPN card widget in NTP brave/brave-core
3 participants
@rebron @simonhong @brave-builds