Split crate into an implementation crate and the redis module crate #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This facilitates embedding elsewhere as a static module, rather than as a shared object file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this will be of interest, but I have a use case where I embed the implementation with the option of using a redis client to talk to the redis module embedded there.
In that scenario, I want to avoid the embedded version linking as a shared object file.
This PR splits the crate into two parts;
redis-cell-implwhich has the generic store and cell portions from the original crate, andredis-cellwhich holds the redis module implementation.I've updated to the 2021 edition of Rust as part of this and addressed the current set of clippy warnings.