-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge App Switch Checkout Feature Branch #1519
Conversation
* add initial commits for updating `BTPayPalRequest` with app switch properties * add changelog.md entry * address pr feedback * cleanup * cleanup doc string * address pr feedback
This reverts commit 26cfe78.
* make changes to launch pp app for checkout flow * address failing unit test * address pr comments * address pr feedback * disable unit test * clean up and address pr feedback * clean up and re-add test/relevant errors * fix warning * address swift lint error
* add token param * update parsing logic * fix linkType bug * remove token parameter as we expect gw to pass this in redirectURL
Following up. App switch did work to Venice and back. Only issue observed is needing to log in twice but that's on the Venice side. |
@agedd I did some testing and the app switch is working. This could be beyond our scope but I did notice that when I changed the email for buyer address on the client side it didn't really get picked up on the Venice app. Curious if this is the expected response. |
Also, likely outside our scope but worth raising is this weird glitch on their "log in to PayPal" page when tapping on "log in". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agedd I left a couple comments that might require follow up but approving for now. 👏
ty for letting me know @jwarmkessel! will let the venice team know about these concerns |
Summary of changes
Checklist
Authors