Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge App Switch Checkout Feature Branch #1519

Merged
merged 14 commits into from
Feb 20, 2025
Merged

Conversation

agedd
Copy link
Contributor

@agedd agedd commented Feb 12, 2025

Summary of changes

  • Merge app-switch-feature branch into main

Checklist

  • Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

agedd and others added 9 commits November 22, 2024 13:29
* add initial commits for updating `BTPayPalRequest` with app switch properties

* add changelog.md entry

* address pr feedback

* cleanup

* cleanup doc string

* address pr feedback
* make changes to launch pp app for checkout flow

* address failing unit test

* address pr comments

* address pr feedback

* disable unit test

* clean up and address pr feedback

* clean up and re-add test/relevant errors

* fix warning

* address swift lint error
* add token param

* update parsing logic

* fix linkType bug

* remove token parameter as we expect gw to pass this in redirectURL
@agedd agedd requested a review from a team as a code owner February 12, 2025 18:20
@warmkesselj
Copy link
Contributor

warmkesselj commented Feb 13, 2025

Able to verify that an app switch is happening, however, unable to login to Venice with the test user(s) credentials:

Simulator Screenshot

@warmkesselj
Copy link
Contributor

Following up. App switch did work to Venice and back. Only issue observed is needing to log in twice but that's on the Venice side.

@warmkesselj
Copy link
Contributor

@agedd I did some testing and the app switch is working. This could be beyond our scope but I did notice that when I changed the email for buyer address on the client side it didn't really get picked up on the Venice app. Curious if this is the expected response.

@warmkesselj
Copy link
Contributor

warmkesselj commented Feb 19, 2025

Also, likely outside our scope but worth raising is this weird glitch on their "log in to PayPal" page when tapping on "log in".

Copy link
Contributor

@warmkesselj warmkesselj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agedd I left a couple comments that might require follow up but approving for now. 👏

@agedd
Copy link
Contributor Author

agedd commented Feb 20, 2025

Also, likely outside our scope but worth raising is this weird glitch on their "log in to PayPal" page when tapping on "log in".

ty for letting me know @jwarmkessel! will let the venice team know about these concerns

@agedd agedd merged commit 258ae49 into main Feb 20, 2025
7 checks passed
@agedd agedd deleted the app-switch-checkout-feature branch February 20, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants