Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] Move /authenticate_from_jwt POST to Encodable #1513

Merged
merged 3 commits into from
Feb 6, 2025
Merged

[v7] Move /authenticate_from_jwt POST to Encodable #1513

merged 3 commits into from
Feb 6, 2025

Conversation

agedd
Copy link
Contributor

@agedd agedd commented Feb 4, 2025

Summary of changes

  • Move the JSON dict of the POST body sent to this endpoint /three_d_secure/authenticate_from_jwt into an Encodable Type

Checklist

  • [ ] Added a changelog entry
  • Tested and confirmed payment flows affected by this change are functioning as expected

Authors

List GitHub usernames for everyone who contributed to this pull request.

@agedd agedd requested a review from a team as a code owner February 4, 2025 23:09
jaxdesmarais
jaxdesmarais approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting comment but otherwise looks good

@agedd agedd merged commit 666e6ff into v7 Feb 6, 2025
6 of 7 checks passed
@agedd agedd deleted the dtmobiles-1175-move-/authenticate_from_jwt-post-to-encodable branch February 6, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo left review comments

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@warmkesselj warmkesselj warmkesselj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agedd @jaxdesmarais @scannillo @warmkesselj