-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update iso2mesh version for ARM #727
base: master
Are you sure you want to change the base?
Conversation
how does brainstorm unzip the zip file? using regular unzip, the
|
oh actually you are right, permission are fine. Issue i got was because of the file being deleted. |
@Edouard2laire, could you identify which removed file(s) are the culprits? @tmedani, besides the comments in |
i am not sure how. Seems it would require a lot of try and error. So i tried to delete everything expet tetgen files, but i still get the same error with the following log file:
Here is a more precise error of what happens here: https://github.com/fangq/brain2mesh/blob/master/brain2mesh.m#L361
i don't understand how not deleting file could solve the issue; so identifying which file to keep is outside of my skill set. |
Hey team,
we did some tests and selected only the dependencies required by the process_fem_mesh.m I agree with @Edouard2laire, testing all the cases with all dependencies can be tedious. Maybe we can just remove those
and keep all the other files. |
if you try the same input for brain2mesh on windows or Linux and they do not crash tetgen, then I think it is likely caused by the updated cgal version when the arm64 mac binaries were compiled (v5.x vs v3.x) if you can share the matlab variables used for the brain2mesh call, I can also take a look |
@Edouard2laire, FYI, I tested both built-in examples of brain2mesh on my M2 Mac, and both worked fine. |
@Edouard2laire, are the new binaries working ok with brainstorm? |
@Edouard2laire, FYI, I added a missing cgalsimp2 binary for arm64 mac |
thx. i will do some test later this week |
Hello,
Iso2mesh was updated to support ARM: https://x.com/FangQ/status/1801795041867776036
This now download iso2mesh directly from github to get this updated version.
Also, it doesnt work if i keep:
i get an error with tetgen. But if i dont delete any file, then it works great:
cc: @fangq