[EDF] reading EDF using fieldtrip #690
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @rcassani, What do you think of that PR? Would that solution be ok for you? |
|
up :) i think this is a good solution for now; we can remove it when brainstorm supports edf with multiple frequency :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The main point of this PR is to use fieldtrip to open edf containing multiple frequencies as the reader of edf is automatically resampling signals with different frequencies.
it's a bit hacky but it seems to be working and it might be easier than rewritting our current edf reader to account for different frequencies
Edouard
Edit: performance can be nicely improved by not saving the .mat file and giving directly the data structure to in_data_fieldtrip. I will do that If you think the rest of the PR is ok :)