Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specifying media uris for google vertex #242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattmatters
Copy link

Changes data => fileUri.

@brainlid
Copy link
Owner

Thanks @mattmatters! I haven't looked into this but I'd love some more information. My guess is that the file data could be Base64 encoded (so the file is uploaded directly), or it could support the fileUri for where it could be downloaded from.

If so, I'm hesitant to break a potentially working solution for some people.

@mattmatters
Copy link
Author

Thanks @mattmatters! I haven't looked into this but I'd love some more information. My guess is that the file data could be Base64 encoded (so the file is uploaded directly), or it could support the fileUri for where it could be downloaded from.

If so, I'm hesitant to break a potentially working solution for some people.

Oh sorry I should have supplied more details, I can check on inline data but even just having the data key set at all results in the vertex api returning a 400 error saying that an unknown key data is set. So I don't believe that this has worked for anyone yet.

I did leave the inline data field alone though above it as I haven't been working with inline data and didn't want to mess with that for folks.

@mattmatters
Copy link
Author

Just to follow up here I tested with setting inline data to the image_url type and it also does not work. I don't believe this codepath has ever worked for vertex ai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants