feat: apply chat template from callback #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joelpaulkoch! I love this approach. It provides a nice future-proof way of adding one-off support for some Bumblebee hosted model. As an FYI, this was just merged: #233 But I still want merge in your approach too. |
brainlid
added a commit
to montebrown/langchain
that referenced
this pull request
Jan 22, 2025
* main: feat: Support for Ollama keep_alive API parameter (brainlid#237) support for o1 OpenAI model (brainlid#234) minor test cleanup phi_4 chat template support fix after merge feat: apply chat template from callback (brainlid#231) Add Bumblebee Phi-4 (brainlid#233) updated changelog update version and docs outline (brainlid#229) fix: enable verbose_deltas (brainlid#197) feat: Enable :inet6 for Req.new (brainlid#227) Breaking change: consolidate LLM callback functions (brainlid#228)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to work with Phi-4 which has a slightly different chat template than previous versions.
I could add the template but I figured some time ago it would be practical to be able to pass a callback to
apply_chat_template!/3.This way, users don't have to wait for an release to use a new template.
So, here is a PR.
I might go ahead and add the
phi-4template in a separate PR.