Fix specs and examples #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retry_count is supposed to be an non-negative integer, not a function. Since the function raises sometimes, added no_return() as well
brainlid
reviewed
Dec 12, 2024
Clarified the description for the list of models
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for creating LangChain - it's a very useful library!
Apologies for unsolicited PR, but I decided to fix some low-hanging spec errors that dialyzer was complaining about, and also fixed
README.mdto use the new return type forLLMChain.run().There are still a few dialyzer errors left but they are a bit more cryptic.
Hope that works!