Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_abinit_WFK stores k-point mesh correctly #192

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

brainandforce
Copy link
Owner

Previously we noticed that read_abinit_WFK did not store the KPointMesh from the header data. This should fix #191.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fd86efb) 58.60% compared to head (0a4ba9f) 59.17%.

❗ Current head 0a4ba9f differs from pull request most recent head d5d5167. Consider uploading reports for the commit d5d5167 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   58.60%   59.17%   +0.57%     
==========================================
  Files          19       19              
  Lines        1406     1411       +5     
==========================================
+ Hits          824      835      +11     
+ Misses        582      576       -6     
Files Coverage Δ
src/data/wavefunctions.jl 75.00% <100.00%> (+2.69%) ⬆️
src/software/abinit.jl 48.74% <83.33%> (+1.90%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce merged commit 1aaec7a into main Nov 2, 2023
3 checks passed
@brainandforce brainandforce deleted the fix/abinit-kptmesh branch November 2, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_abinit_WFK does not store k-points
1 participant