Syncing from upstream OCA/commission (15.0) #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - Create a product commission free. - Do some invoices with that product. - There's no commission on the invoices. - Remove the "Commission free" check. Result: all the past invoices are recomputed and now a commission appears. That's not acceptable, as past things shouldn't be changed if you change the definition from now on, and more if you already did the settlements. This happens because the field in the invoice line is a related one, so changing the source, recomputes all the linked records. Let's change it to a computed writable, being recomputed only when the product changes, not if we change the . TT50445
That way, deletions of agent lines in invoices are faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot