optimisation of the vertex vornoi function #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpron
requested changes
Aug 18, 2021
There was a problem hiding this comment.
Thank you for taking the time to optimize the vertex voronoi function @MaximeDdnn. Your contribution will greatly help us. Hereunder are some comment/suggestions regarding the PR:
- linting (import should be ordered from python to module)
- function names (voronoi de papa, toto should be removed)
- pandas is an important dependency that could be replaced by numpy only
I ll have a further check on the code and suggest some modifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimisation of the vertex vornoi function : vornoi area compure in less than 10s instead of more than 3min for a mesh in oasis database, stricly identical output of the old version