Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to LibraryGeneration Model #90

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

puja-trivedi
Copy link
Collaborator

@puja-trivedi puja-trivedi commented Nov 22, 2024

  • fix ValueError: Conflicting URIs (https://identifiers.org/brain-bican/genome-prov-schema, https://identifiers.org/brain-bican/library-generation-schema) for item: used

  • NIMP prefix was missing from spreadsheet. However, this addition will not change the model because LinkML will automatically define any missing prefixes so in library_generation.yaml "NIMP" was always defined.

  • Changed 'R1/R2 index name' slot to 'R1_R2 index name' because pydantic does not allow slash (/) in identifiers

@puja-trivedi puja-trivedi changed the title added NIMP prefix definition to library generation model spreadsheet Updates to LibraryGeneration Model Nov 22, 2024
@puja-trivedi puja-trivedi marked this pull request as draft November 22, 2024 20:49
…l spreadsheet. This is an attempt to resolve 'ValueError: Conflicting URIs for item:used'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant