feature/rails4 compatibility #52
Open
+120
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great. |
|
@chytreg Are you thinking of submitting a PR for Rails 4 compatibility? |
|
Hold on, this is a PR, sorry... |
|
:) |
|
+1. @bradphelan any chance you could accept this pull request? Thanks! |
|
ping. I wonder if this PR is backwards compatible with Rails 3. I think that the specs need running against both ActiveRecord 3 and 4. Ideally Travis would tell us this, I'd be happy to submit a seperate PR for Travis support, running the specs for both ActiveRecord 3 + 4. |
|
How about having a rails 3 branch and keep rails 4 in master? |
|
bump :) |
|
@chytreg do you have a version for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
rocket_tag doesn't work with rails 4
I tired to solve squeel dependancy, change scope to lambda
you should add also
gem 'protected_attributes'This solution is a hack to get rocket_tag to works, but it's incompatible with previous Rails version.