Rework: new convert() API, higher performance, remember preferred unit exactly #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fairly significant refactor that:
.convert()
API so you can convert to your preferred unit while still getting aQuantity
object. The previous.getWithUnits()
API for conversions did not return aQuantity
object, so was less useful.Quantity
instance remembers what units it was initialized with, and will use those as the default output unit. (Previously only the "hint" of what unit to use was remembered, and this required more computation at each step to determine the actual exact unit to use).luminosity
andangle
dimensions. Just left one unusedplaceholder
dimension for now. You can still add as many custom dimensions as you want.